Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return updateComplete at the end of requestUpdate #472

Closed
wants to merge 4 commits into from
Closed

Do not return updateComplete at the end of requestUpdate #472

wants to merge 4 commits into from

Conversation

Christian24
Copy link
Contributor

This addresses an issue mentioned in #469. When implementing custom accessors, TS-Lint always has a finding on calling requestUpdate, because the result of the returned promise is ignored. As async and await is not supported in accessors anyway, my suggestion is to just not return updateComplete, as the return value is never used in the source code anyway and can easily be substituted for updateComplete get accessor if needed.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@Christian24
Copy link
Contributor Author

I need to work some more on this, before it is ready. Sorry, for the fast first shot.

@Christian24 Christian24 reopened this Jan 23, 2019
@Christian24
Copy link
Contributor Author

I guess the CLA check failed, because I have used to a different email address in my first commit.

@daKmoR
Copy link
Contributor

daKmoR commented Jan 23, 2019

for the cla I think you should just erase your history and make a new commit and then force push

e.g. something like this

git reset --soft <hashOfLastCommitThatIsNotYours>
git commit ...
git push --force

@Christian24
Copy link
Contributor Author

Since @justinfagnani made clear in #469 this won't be merged, because of the API change, I will close this now. Would love to have an option like requestUpdateSync in the future though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants