Do not return updateComplete at the end of requestUpdate #472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue mentioned in #469. When implementing custom accessors, TS-Lint always has a finding on calling
requestUpdate
, because the result of the returned promise is ignored. As async and await is not supported in accessors anyway, my suggestion is to just not returnupdateComplete
, as the return value is never used in the source code anyway and can easily be substituted forupdateComplete
get accessor if needed.