Repository navigation
sync: merge upstream 69a147dfc (native LoRA #1792) - #46
Merged
Merged
Conversation
…(#1792) Co-authored-by: yueming-yuan <yym022502@gmail.com>
…ount (#4099) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fork-Infra: sync-69a147dfc
Fork-Infra: sync-69a147dfc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
main takes the next upstream image, which adds upstream's native LoRA framework. This is the base the DeepSeek-V4.1 LoRA work builds on; on its own it changes nothing for the recipes we run.
af4413b74(2026-10-14)69a147dfc(2026-10-16), 6 upstream commitsradixark/miles:devb836fec…radixark/miles:dev-202610160544c64fa34…7b6993a/9df207fmiles/backends/megatron_utils/lora/native/)69a147dfcis the first upstream commit after #1792 that a published upstream image was built from (read from the image's/root/miles/.git), as the rulebook requires for a between-releases sync.Contract
radixark/miles:dev@sha256:c64fa344e3a86715f03c0a1b6a422c474e0035355591a2f6da87bf52a74c52da; same CUDA, torch, SGLang and Megatron commits. Python packages are unchanged: nodocker/,requirements.txtorpyproject.tomlchange in the range.upstream:v0.1.2+69a147dfc2.--log-probs-max-tokens-per-gpu(#4118). No recipe inmiles_extsets it.Side-effects
The six upstream commits:
miles_plugins/models/{kimi_k3,inkling}/lora.pyare deleted) with a registry and per-architecture specs. Only active with--lora-*flags.--skip-actor-forward-only. Opt-in.--log-probs-max-tokens-per-gpu.No merge conflicts; no fork fix or hook needed re-applying. Open PRs #36 and #45 do not touch the changed files.
Done
69a147dfc(Fork-Infra: sync-69a147dfc).miles_ext/stack.py:UPSTREAM_BASEandBASE_IMAGEfor that commit.Verification
python fork/tools/ledger.py check: ok (119 fork commits, 43 upstream files touched).fork/vendored.json: the only vendored file (Harborsail.py) is outside the range.fork/tools/sync.py): onlymiles/utils/arguments.py(the flag removal above).pytest miles_ext/tests tests/fast/backends/megatron_utils/lora tests/fast/backends/megatron_utils/test_{lora_utils,lora_model_branches,checkpoint,model_initialize}.py: 419 passed, 10 skipped..gitrefs (2026-10-19): Miles 69a147d, SGLang (sglang-miles) 7b6993a31, Megatron-LM (miles-main) 9df207fd1. SGLang and Megatron are the same commits as the previous base image, so theBASE_IMAGEcomment's "plus 9 SGLang and 1 Megatron commits" still holds.--check-onlyfrom this head (image built by Modal from 7b43958, recipe dsv41-flash-tb4-overfit16, 1 H100):check: ok. The CPU-only parse fails with "CUDA driver is a stub library", as it does on main (Megatron's parse_args needs CUDA).