You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quick and dirty fix for recent changes in the strava route builder (just to give an idea what's changed); I can't do it properly at the moment but I hope this will help somehow anyway
liskin
linked an issue
Jun 11, 2023
that may be
closed
by this pull request
Did you have an idea of what "doing it properly" would look like? After looking at your change I'm thinking that we can just always try both of reactInternalInstance/reactFiberand both of mapFromReactInternalInstance/mapFromReactFiber, rather than only doing mapFromReactFiber when reactFiber finds something. It's still a hack probably but doesn't seem harmful. I can't really be bothered studying what React actually does in different versions.
Anyway, thanks a lot for figuring this out! ❤
I'll try to take a closer look next week (expecting to be somewhat less busy but no promises really).
It seems that Strava updated its version of React so I believe it is safe to assume that reactInternalInstance is gone and sticking to reactFiber will suffice. I cleaned up the fix a bit.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quick and dirty fix for recent changes in the strava route builder (just to give an idea what's changed); I can't do it properly at the moment but I hope this will help somehow anyway