[Manual Test] [Core] prompt_preprocess_func in stage config (upstream #2796)#26
Closed
lishunyang12 wants to merge 1 commit into
Closed
[Manual Test] [Core] prompt_preprocess_func in stage config (upstream #2796)#26lishunyang12 wants to merge 1 commit into
lishunyang12 wants to merge 1 commit into
Conversation
…mpt formatting Signed-off-by: adamkbaranowski <adam.baranowski@protonmail.com>
|
Preview (Haiku) What it does: Adds server-side prompt preprocessing hook that transforms raw user prompts before Stage 0 tokenization, enabling chat template or system prompt formatting without client-side changes. Risk flags: Modifies critical request initialization path. Test coverage gaps: no integration test of the actual preprocessor execution during request creation, only metadata loading/collection. [Core] prefix implies scheduler/thread-safety checks — concurrent requests must safely invoke the preprocessor function. Suggested depth: |
Owner
Author
|
Closing — tone + link updates applied. New test PR follows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh test PR after tightening the
claude-quickpreview prompt.Mirrors upstream vllm-project#2796 —
[Core] Add prompt_preprocess_func to stage config(5 files / 208 lines). Uses the[Core]title prefix so the bot's Phase 1 will trigger the Core-specific checks (scheduler invariants, thread safety, high bar for tests).Try the three tiers in order
claude-quick(Haiku) — should now give you a short signal-only preview: domain summary + risks + depth rec. NO file-by-file lists, NO meta fluff.claude-review(Sonnet) — full Phase 0–3 maintainer review.[Core]prefix should trigger scheduler/thread-safety checks in Phase 1.claude-deep(Opus) — same scope as Add claude review #2, stronger reasoning for subtle concerns.Compare the three outputs. The Haiku preview should be short and straight — if it still pads with file lists or meta reciting, the prompt isn't tight enough. Do not merge.