[Manual Test] Bagel multi-stage cfg bugfix (upstream #2801)#24
Closed
lishunyang12 wants to merge 5 commits into
Closed
[Manual Test] Bagel multi-stage cfg bugfix (upstream #2801)#24lishunyang12 wants to merge 5 commits into
lishunyang12 wants to merge 5 commits into
Conversation
Signed-off-by: princepride <wangzhipeng628@gmail.com>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
|
Preview (Haiku) What this PR does: Fixes a multi-stage CFG (Classifier-Free Guidance) bug in the Bagel diffusion pipeline where the condition for injecting KV cache was incorrect, and updates test reference pixel values to match the corrected behavior. Meta check:
Files touched:
Depth recommendation: |
Owner
Author
|
Closing — preview prompt tightened. New test PR to follow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test the maintainer-style review bot with 3 tiers.
Mirrors upstream vllm-project#2801 —
[BugFix]: Fix multi-stage cfg bug(4 files / 106 lines, Bagel diffusion pipeline + stage input processor + 2 tests).Try all three tiers
Apply each label in turn (wait for each to finish before adding the next):
claude-quickclaude-reviewclaude-deepclaude-review, but with stronger reasoning for subtle cross-file concerns.What to compare
claude-quickactually help you decide whether to do a deep review? Or is it fluff?claude-reviewmatch what a human maintainer would flag?claude-deepfind thingsclaude-reviewmissed?Do not merge.