Rewrite review bot as a maintainer, not a counter#23
Merged
Conversation
…jobs Signed-off-by: lishunyang <lishunyang12@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pivot the review bot from 'bot with comment caps' to 'maintainer with a checklist'. Based on vllm-omni's own
docs/contributing/(title prefixes, DCO, 5-level tests, RFC gate) plus the vllm-omni-skills catalog.What changed
Three tiers, three real jobs (not one job at three depths):
claude-quickclaude-reviewclaude-deepclaude-review, stronger reasoningDropped hard caps. No '2-6 comments max'. A PR that warrants 15 gets 15; a PR that warrants 0 gets 0 and an empty approve.
Phase 0–3 maintainer flow (full review mode):
[Model],[Quantization],[Kernel],[Hardware], etc.) — each has its own checklist drawn fromdocs/contributing/No
@claudetrigger. Single mechanism = labels.Rationale: a Haiku 'LGTM' isn't valuable — a Haiku preview is. Capping Sonnet/Opus at 6 comments makes the bot useless on big PRs. Real vllm-omni maintainers follow a category-specific checklist; the bot should too.