Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recommended config #2

Closed
Uzlopak opened this issue Nov 12, 2021 · 4 comments · Fixed by #3
Closed

add recommended config #2

Uzlopak opened this issue Nov 12, 2021 · 4 comments · Fixed by #3
Labels

Comments

@Uzlopak
Copy link

Uzlopak commented Nov 12, 2021

Please add a recommended config.

I am thinking of integrating your eslint plugin into my projects. When I see that somebody published a new version of an eslint-plugin by hovering in vscode over the corresponding line in my package.json then I want just upgrade the package and know that if a rule was added that it is already covered by the "recommended"-config and so i dont have to touch the .eslintrc file also.

Currently I would need to check the new version if there is a useful new rule added and add it manually to my project, instead of being immediatly secured by the new rule.

Thank you for your work.

@lirantal
Copy link
Owner

That's a good idea. Would you like to contribute that to this project? I'm happy to merge your pull request.

@lirantal lirantal added the good first issue Good for newcomers label Nov 13, 2021
@Uzlopak
Copy link
Author

Uzlopak commented Nov 16, 2021

TBH: When I created this issue, I first checked if I could provide a PR, but I didnt find any simple example on how to add a config to a plugin. Googling for eslint plugin configuration does not give a simple solution. And checking other bigger plugins for sample code didnt help as it was always overcomplicated. So I have to decline unfortunately. :(

@lirantal
Copy link
Owner

There's a bit on that here https://eslint.org/docs/6.0.0/user-guide/configuring#using-eslintrecommended and also here https://www.freecodecamp.org/news/creating-your-own-eslint-config-package/ incase you wanted to give it a try still :)

travi added a commit to travi/eslint-plugin-anti-trojan-source that referenced this issue Dec 28, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants