Introduce overwrite highlight functionality to sheet
#357
+75
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… double-free issue
Sheet edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
When using
--apply-overwriteswithzsv sheet, the overwritten cells will be displayed with an underline.Added two tests, test-sheet-apply-overwrites and test-sheet-overwrites-underlined. These test that the overwrites work as well as checking the underlining functionality.
Issue discovered:
I noticed that when using
--apply-overwrites, there was segfaults caused by double-free issues. This comes from thezsv_overwrite_context_deletefunction inutils/overwrite.c. The context structure as well as thesrcfield in the structure are both freed, but they are then used later, and freed again (somewhere in zsv_delete).To fix this, I've just commented out the lines that free these fields, which does introduce a memory leak.
It seemed out of scope for this PR. I can either work on fixing this issue, if you want, or it can be addressed by someone else. Just let me know where you want to go from here.
I wanted to get this working, so commenting out the lines allows it to run properly, so that I could make sure everything works.