sheet extension and index cleanup #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix possible race condition w uibuff->index_started
on extension build, rebuild libzsvutil if stale
to do: consolidate index.c and transformation.c
remove index.h from external api
review writer.c for performance
remove index.c from libzsvutil
richiejp
reviewed
Dec 19, 2024
| @@ -207,6 +207,8 @@ static int read_data(struct zsvsheet_ui_buffer **uibufferp, // a new zsvsheet_ | |||
| pthread_mutex_lock(&uibuff->mutex); | |||
| char need_index = !uibuff->index_started && !uibuff->write_in_progress; | |||
| char *old_ui_status = uibuff->status; | |||
| if (need_index) | |||
| uibuff->index_started = 1; | |||
There was a problem hiding this comment.
Just wondering; I don't think there should be a race condition here because the UI buffer should not have a worker attached at this point and this is executing in the main thread?
There was a problem hiding this comment.
You're probably right but this way we don't have to think about it, or worry about some change in the future adding a worker before this block executes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix possible race condition w uibuff->index_started on extension build, rebuild libzsvutil if stale
to do:
consolidate index.c and transformation.c
remove index.h from external api
review writer.c for performance