sheet: Fix cursor movement after transformation #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Add memory barriers to ensure row count updates are visible - Add mutex protection for UI buffer dimension updates - Document thread safety requirements Fixes #345 Co-Authored-By: Matt Wong <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
…formation-cursor' into devin/1734550962-fix-sheet-transformation-cursor Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
… memory barriers Co-Authored-By: Matt Wong <[email protected]>
…mpatibility Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
…atibility Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
Co-Authored-By: Matt Wong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #345
Added atomic operations for bit field updates to ensure proper thread synchronization, particularly important for macOS memory ordering.
Changes:
Testing:
Link to Devin run: https://app.devin.ai/sessions/2dede99506024675a14d5fbc55f38c71