Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] MacOS codesignging + notarization #340

Merged
merged 49 commits into from
Dec 17, 2024
Merged

[CI] MacOS codesignging + notarization #340

merged 49 commits into from
Dec 17, 2024

Conversation

iamazeem
Copy link
Collaborator

@iamazeem iamazeem commented Dec 12, 2024 •
edited
Loading

  • Update CI for MacOS codesigning and notarization
    • Separate job for macos builds
    • Use 30m timeout to account for potential delay during notarization for releases
    • Generate .zip archives only. The .tar.gz format is not supported for notarization
    • Codesign and notarize the release builds only
  • Reference for potential TODOs if needed: Avoid long notarization response times and size limits

Signed-off-by: Azeem Sajid [email protected]

@iamazeem iamazeem added the enhancement New feature or request label Dec 12, 2024
@iamazeem iamazeem self-assigned this Dec 12, 2024
@iamazeem
Update trigger
326dd6e
@iamazeem
Specify algorithm [skip ci]
a917cd6
@iamazeem
Ignore this workflow in main CI
be3100a
@iamazeem
Use main workflow instead (disable other jobs)
28e10fc
@iamazeem
Use OpenSSL 1.1
88584a3
@iamazeem
Try to import key and cert separately
6eb9d9f
@iamazeem
List key and crt file; fix password
c874292
@iamazeem
Use -passin flag
779ae27
@iamazeem
Print OpenSSL version; use password directly
c95377e
@iamazeem
Run on both macos 13 and 14
24dba50
@iamazeem
Check if cert pwd is base64 encoded
e4de9cb
@iamazeem
Trim trailing newline
ac77184
@iamazeem
Revert debugging changes
3c4358e
@iamazeem
Check with thirdparty action
f608221
@iamazeem
Fix zsv path
6effb55
@iamazeem
Fix copy
a98da2f
@iamazeem
Verfieid, got same error with thirdparty action; revert
ac185e9
@iamazeem
Add initial script [skip ci]
ff93f74
@iamazeem
Validate OS
d32cc70
@iamazeem
Dump output JSON for notarization
eb51138
@iamazeem
Build ZIP bundle
9aee50e
@iamazeem
Update paths
e509931
@iamazeem
Cleanup
e9e3915
@iamazeem
Validate notarization response
5b8a159
@iamazeem
Commit intermediate script updates [skip ci]
df56cd1
@iamazeem
Remove entitlements stubs [skip ci]
6aa4b04
@iamazeem
Fix prepare script for consecutive use [skip ci]
43a80a6
@iamazeem iamazeem requested a review from liquidaty December 14, 2024 14:12
@iamazeem
Copy link
Collaborator Author

@liquidaty: Please review and test. Thanks!

Latest workflow: https://github.com/liquidaty/zsv/actions/runs/12330433315

liquidaty
liquidaty approved these changes Dec 17, 2024
View reviewed changes
Copy link
Owner

@liquidaty liquidaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me; pls lmk if anything that deserved particular attention / concern otherwise go ahead and merge

@iamazeem iamazeem merged commit ef63e5a into main Dec 17, 2024
@iamazeem iamazeem deleted the macos-codesigning branch December 17, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liquidaty liquidaty liquidaty approved these changes

Assignees

@iamazeem iamazeem

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamazeem @liquidaty