Close open files on caller side

[iamazeem]

• Referece: fix recent bug in writer that closed stream, which should be left to caller to manage #307
  • Need to close files to flush data
• Fix favicon for playground
• Exit test-sheet-1 session properly
• Fix test-sheet-12 intermittent failures
  • Add delay before capturing output
  • Update expected output accordingly

Signed-off-by: Azeem Sajid [email protected]

[iamazeem]

@liquidaty: Please review and merge. Thanks!

[liquidaty]

@iamazeem thank you, this is helpful in pointing out all the current areas that need fixing and proposing a solution. The only reason we are not merging this right away is that we will likely pursue an alternate solution which would be for the writer options to have output_filename that could be used instead of stream, whereby in zsv_writer_new(), if output_filename is specified then stream would be opened there, in which case it would also be closed by zsv_writer_delete().

[iamazeem]

@liquidaty: Makes sense. 👍
However, without it, the commands with missing fclose won't work in playground.
The flushing is not being done in this case.

Also, the above solution would work the same for commands such as 2json, 2db, etc. where the writing is not CSV format? 🤔
How is the non-CSV format going to be encapsulated?

IMO, it may be done incrementally i.e. merge this one first and then iterate with the new solution.

[liquidaty]

Superseded by #310