Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added editor subcommand. #300

Merged
merged 14 commits into from
Dec 8, 2024

Conversation

br1tney5pear5
Copy link
Contributor

This PR adds editor subcommand, subcommad is just another proc triggered by keybinding which then parses user input and executes the procedure user specified, e.g. :open or :filter. All named procedures are accessible from subcommand.

Furthermore args can be provided on invocation like :open data/fixed.csv. Open and filter procedures were adapted to only prompt user for input if the argument wasn't provided.

Lexer for the subcommand is smart enough to recognise strings with spaces and escapes as single tokes so e.g. this is completely fine :open "data/insane \" : file \" name.csv"

@liquidaty
Copy link
Owner

@br1tney5pear5 sounds great. Could you please add some tests that cover this new feature, that run as part of the test-sheet target in app/test/Makefile? Please give the new tests a less generic prefix than the existing tests (e.g. test-sheet-subcommand-N rather than test-sheet-N), as the various sub-targets are starting to get lengthy and we'll want to make it easier for ourselves to move them into a separate app/test/sheet/Makefile (though that move can wait until after this is done).

@br1tney5pear5
Copy link
Contributor Author

@liquidaty 4 basic test-sheet-subcommand were added

@liquidaty liquidaty merged commit dfb4bfb into liquidaty:main Dec 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants