-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce more features to overwrite
command
#290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@CobbCoding1 thank you. Could you pls make further changes as follows?
|
Alright, I'll get right on that. |
OK, I think that's everything. Let me know if there's any more changes I should make. |
…e not supported yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
remove
subcommandbulk-add
subcommandbulk-remove
subcommand--old-value
flag--force
flagThe remove command works as expected, you pass the position you want to remove, and it deletes it from the database.
The bulk-add and bulk-remove flags both work similarly, as laid out in the usage message.
overwrite <dummy.csv> bulk-add <bulk.csv>
It can have the columns: row, col, val, author, timestamp, and old value.
The old-value and force flags also work as expected.
Some stylistic changes are that I've restructured the program, so there's an outer struct
zsv_overwrite
which passes thectx
,args
, andoverwrite
around the functions, to avoid clutter in the functions. It also contains necessary information for thebulk
operations, such as keeping track of the index of the columns.Finally, I've added tests for every feature added here and their functionality.