Add help buffer #289
Merged
Add help buffer #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richiejp
force-pushed
the
sheet-help
branch
3 times, most recently
from
f08d018 to
2b6edca
Compare
|
Don't need to add a type to the UI buffer for this because we can check if there is a file name so I crossed that out. Either a type or some way for event handlers/procedures to be swapped out will be needed if more buffer types are added or if extensions are to be able to hook into this. |
Pressing the escape key pauses for 1 second while curses waits for an escape sequence. This reduces it to 30ms so there isn't any noticeable latency. I can only assume this is OK on a modern virtual terminal.
It seems in most shells echo does not default to interpreting escape sequences so add -e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a help buffer activated by pressing '?'
The initial version is slightly different from planned because it uses 3 columns instead of 1 to help with layout.
TODO:
Add a type to the UI buffer that the event handlers can read and make sure invalid handlers do not run on help