Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions: remove extraneous message on non-zero extension exit; fix… #278

Merged
merged 1 commit into from
Nov 9, 2024
Merged

extensions: remove extraneous message on non-zero extension exit; fix… #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions app/cli.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,7 @@ static int handle_ext_err(struct zsv_ext *ext, zsv_execution_context ctx, enum z
if (ext->module.errfree)
ext->module.errfree(errstr);
}
} else
fprintf(stderr, "An unknown error occurred in extension %s\n", ext->id);
}
return rc;
}

Expand Down Expand Up @@ -454,7 +453,7 @@ static enum zsv_ext_status run_extension(int argc, const char *argv[], struct zs
struct zsv_execution_data ctx = {0};
if ((stat = execution_context_init(&ctx, argc, argv)) == zsv_ext_status_ok) {
struct zsv_opts opts;
zsv_args_to_opts(argc, argv, &argc, argv, &opts, ctx.opts_used);
zsv_args_to_opts(argc, argv, &ctx.argc, ctx.argv, &opts, ctx.opts_used);
zsv_set_default_opts(opts);
// need a corresponding zsv_set_default_custom_prop_handler?

Expand Down