Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend and fix overwrite command #272

Merged
merged 60 commits into from
Nov 9, 2024
Merged

Extend and fix overwrite command #272

merged 60 commits into from
Nov 9, 2024

Conversation

CobbCoding1
Copy link
Contributor

This PR introduces:

  • Adds --A1 flag to add
    • Allows the user to use excel-style cells (A1 is quivalent to 0-0)
  • Adds --no-timestamp flag to add
    • Saves the overwrite without a timestamp, leaves it blank
  • Changes timestamps to use unix time rather than a date format
  • Adds more tests
  • Fixes issue with timestamps in the tests falling behind, causing a test error

CobbCoding1 and others added 30 commits October 24, 2024 16:32
@CobbCoding1
Add boilerplate for overwrite command
a50176e
@CobbCoding1
Add more boilerplate for overwrite and update help.c message
5770416
@CobbCoding1
Prepare overwrite implementation
7aca16e
@CobbCoding1
Setup sqlite in overwrite.c and add parsing for non-flag arguments
31e3b89
@CobbCoding1
Add sqlite initialization functions to overwrite, and messages for ce…
c2412a6 
…rtain subcommands
@CobbCoding1
Add simple test for overwrite
fdc5315
@CobbCoding1
clang-format
52fa9a5
@CobbCoding1
Add overwrite command skeleton and initialization (liquidaty#241)
734cddb 
* Add boilerplate for overwrite command

* Add more boilerplate for overwrite and update help.c message

* Prepare overwrite implementation

* Setup sqlite in overwrite.c and add parsing for non-flag arguments

* Add sqlite initialization functions to overwrite, and messages for certain subcommands

* Add simple test for overwrite

* clang-format
@CobbCoding1
Add improved testing for overwrite command
4b6aa33
@CobbCoding1
Update usage and tests to reflect the usage
34cbd79
@CobbCoding1
merge changes
8d350f2
@CobbCoding1
Fix test makefile
2403e6e
@CobbCoding1
Update overwrite tests and usage. (liquidaty#243)
416215c 
* Add boilerplate for overwrite command

* Add more boilerplate for overwrite and update help.c message

* Prepare overwrite implementation

* Setup sqlite in overwrite.c and add parsing for non-flag arguments

* Add sqlite initialization functions to overwrite, and messages for certain subcommands

* Add simple test for overwrite

* clang-format

* Add improved testing for overwrite command

* Update usage and tests to reflect the usage

* Fix test makefile
@CobbCoding1
Update sqlite3_open_v2 to be readonly unless necessary
bf05639
@CobbCoding1
Update arg parsing for some of the new arguments and options
93ec5ce
@CobbCoding1
Implement clear command (untested so far)
75303fb
@CobbCoding1
merge
8b00c55
@CobbCoding1
Add insert command
8237961
@CobbCoding1
Update row and column parsing to use new format
fb6659f
@CobbCoding1
Update tests and prepare overwrite file
5e80735
@CobbCoding1
Update overwrite to integrate better with existing overwrite infastru…
321c06d 
…cture
@CobbCoding1
Update test and add length to output when listing overwrites
b629df6
@CobbCoding1
clang-format
8db9195
@CobbCoding1
remove commented code
6fb667b
@CobbCoding1
Add error message to failed init
8e54a3c
@CobbCoding1
add check for if an overwrite already exists at selected row and colu…
06d669e 
…mn. --force not implemented yet
@CobbCoding1
clang format
0ffddbd
@CobbCoding1
fix build error
f7140e3
@CobbCoding1
Fix test Makefile issue
8ce138e
@CobbCoding1
Update zsvext-test to reflect the usage changes
8ee9bef
CobbCoding1 and others added 28 commits October 31, 2024 15:16
@CobbCoding1
Update overwrite help message, change position to overwrites_uix, add…
1af3f75 
… a zsv_echo --overwrite-auto test, and update to use zsv_csv_writer
@CobbCoding1
Run clang-format
c9c3766
@CobbCoding1
Add header to overwrite list output
ceed2a6
@CobbCoding1
Update to support Excel-style cells
3bc4fb5
@CobbCoding1
clang format
3d1f9b5
@CobbCoding1
update parse_xl_address to be more universal
77890b3
@liquidaty
Update Makefile
2aa20ad
@CobbCoding1
Implement --A1 flag
7e69b08
@CobbCoding1
Merge
accb758
@CobbCoding1
Implement support for parsing no-timestamp (not implemented yet)
010cfd2
@CobbCoding1
Merge branch 'liquidaty:main' into main
813b86c
@CobbCoding1
Merge branch 'main' of github.com:CobbCoding1/zsv into overwrite-command
0c72b36
@CobbCoding1
Implement no-timestamp functionality
59b7718
@CobbCoding1
Change timestamps to UNIX time (tests not updated yet)
e672c5c
@CobbCoding1
Update test to work with UNIX time
5b234d1
@CobbCoding1
Add a few more tests
d3885c4
@CobbCoding1
Update tests to improve the timestamp accuracy. Not completely right …
92822f1 
…yet.
@CobbCoding1
fix issues with timing with dates in the overwrite testing
858c33b
@CobbCoding1
Update tests to use stat command for timestamps
8268bf7
@CobbCoding1
Clang format
487fc74
@CobbCoding1
work more on tests
1fb3743
@CobbCoding1
Fix timestamp test so that it does not fail if it falls a second behind
edaa70b
@CobbCoding1
commit with another csv test file
9bb161c
@CobbCoding1
add expected output
c1ab973
@liquidaty
Update overwrite.c
f610e68 
Fix memory leak
Comment out sqlite3_init and _exit(); if we use these, they will need to be managed consistently across all commands
rename _exit() to _free() for consistency with the rest of project code
@liquidaty
fix test/overwrite/Makefile for bsd/mac
41b8f59
@liquidaty
Update Makefile
2e01af1 
fix test-timestamp to work for alpine
@liquidaty
Update Makefile
6161496 
v2 of prior commit
@liquidaty liquidaty merged commit a7e0c09 into liquidaty:main Nov 9, 2024
11 checks passed
@CobbCoding1 CobbCoding1 deleted the overwrite-command branch November 9, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CobbCoding1 @liquidaty