Cleanup and modularize index #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the basic in-memory index functionality into utils and rework the API to make it easier to use. There is now a seek function which moves the file offset to the exact line-end requested by the user. The temp file generation has not been moved into utils because generalising it started to introduced a lot more callbacks and other complications. This also changes the sheet display code so that (building index) is displayed in the status area while indexing is in progress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the basic in-memory index functionality into utils and rework the API to make it easier to use. There is now a seek function which moves the file offset to the exact line-end requested by the user.
The temp file generation has not been moved into utils because generalising it started to introduced a lot more callbacks and other complications.
This also changes the sheet display code so that (building index) is displayed in the status area while indexing is in progress.