-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] musl build updates #256
Conversation
@iamazeem could you also double-check if these contemplated changes have any measurable impact on the performance benchmarks? |
@liquidaty: Here are the results: Benchmarks (
|
A binary built with SIMD instructions fails with "illegal instruction" error on platforms where those instructions aren't available. |
… ci-musl-build-updates
@iamazeem I'm not aware of any chips from 2018+ that do not have some sort of SIMD capabilities, so is it possible that WITHOUT_SIMD is using unnecessarily conservative assumptions, and the better solution would be to better tailor the build to properly discover and use the available SIMD instructions? Alternatively is there a limitation to the musl compiler's ability to generate correct SIMD instructions for varied platforms? |
Disregard my prior comment, as I did not closely read the above-- thank you, makes sense. Let's include the WITHOUT_SIMD for CI, but not actually publish it (at least for now) upon release. Thank you! |
@liquidaty: |
Benchmarks from the latest run on |
alpine:latest
containerSigned-off-by: Azeem Sajid [email protected]