[WIP] Create in-memory index for sheet command #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow the source directory's mtime gets updated after libjq.a is built, possibly because some object file for the jq cli is created after that. So this copies the directory so that the original is left untouched.
Such as an unused function and the wrong enum type being returned.
richiejp
force-pushed
the
sheet-index-pr
branch
from
4f5ecac to
1a770f4
Compare
richiejp
force-pushed
the
sheet-index-pr
branch
from
1a770f4 to
ca123f0
Compare
clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an in-memory index to the sheet command. The index is built inside a background thread
and once it is complete navigating a 13GB file happens without latency on my development laptop.
TODO:
filteringcheck find works correctlycommits:
Related blog post on adding the index