Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Integrate shellcheck #232

Merged
merged 3 commits into from
Oct 19, 2024
Merged

[CI] Integrate shellcheck #232

merged 3 commits into from
Oct 19, 2024

Conversation

iamazeem
Copy link
Collaborator

@iamazeem iamazeem commented Oct 19, 2024 •
edited
Loading

  • Print tty summary in console logs by default
  • Post tty and diff logs in GitHub step summary (collapsible)
  • Add .shellcheckrc to disable diagnostic(s) globally
  • Lint and fix issues in existing scripts
  • For now, the CI will just report shellcheck issues
    • In future, it may be updated as needed e.g. fail on issues
  • Resolves [CI] Integrate shellcheck #192

Signed-off-by: Azeem Sajid [email protected]

@iamazeem iamazeem added the enhancement New feature or request label Oct 19, 2024
@iamazeem iamazeem self-assigned this Oct 19, 2024
@iamazeem iamazeem requested a review from liquidaty October 19, 2024 11:53
@iamazeem iamazeem merged commit 24bd52f into main Oct 19, 2024
@iamazeem iamazeem deleted the 192-ci-integrate-shellcheck branch October 19, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liquidaty liquidaty Awaiting requested review from liquidaty

Assignees

@iamazeem iamazeem

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Integrate shellcheck
1 participant
@iamazeem