Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] MinGW build with sheet feature #231

Merged
merged 8 commits into from
Oct 20, 2024

Conversation

iamazeem
Copy link
Collaborator

@iamazeem iamazeem commented Oct 18, 2024

  • Separate job for MinGW build
  • Install ncurses with vcpkg
    • Patch its port to enable wide character support
  • Update configure script for sh issues
    • Fix include header and static build flag issues
    • Indent with spaces (tabs to spaces conversion)
  • Tested MinGW ZIP build artifact on Windows 10 (Command Prompt + Powershell)
  • Tested with wine (Windows 7) also under Ubuntu and it's working fine except that Shift key isn't working (maybe, some key bindings issues with wine itself, looked into it a bit, didn't find any permanent solution though)
    • wine: https://www.winehq.org/
    • Command: TERM= wine ./build/win/rel/x86_64-w64-mingw32-gcc/bin/zsv_sheet.exe ./app/test/worldcitiespop_mil.csv

Signed-off-by: Azeem Sajid [email protected]

@iamazeem iamazeem added the enhancement New feature or request label Oct 18, 2024
@iamazeem iamazeem self-assigned this Oct 18, 2024
@iamazeem iamazeem requested a review from liquidaty October 18, 2024 12:27
@iamazeem
Copy link
Collaborator Author

@liquidaty: Please review and merge. Thanks!
Latest workflow run: https://github.com/liquidaty/zsv/actions/runs/11403382759

@iamazeem
Copy link
Collaborator Author

@liquidaty
Resolved merge conflicts.
Updated shellcheck step summary.
Ready for review and merge. Thanks!

Latest workflow run: https://github.com/liquidaty/zsv/actions/runs/11424046380

@liquidaty liquidaty merged commit 9fcfe19 into main Oct 20, 2024
10 checks passed
@liquidaty liquidaty deleted the ci-mingw-build-with-sheet-feature branch October 20, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants