Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Version updates + enable GHCR/container builds #226

Merged
merged 2 commits into from
Oct 13, 2024
Merged

[CI] Version updates + enable GHCR/container builds #226

merged 2 commits into from
Oct 13, 2024

Conversation

iamazeem
Copy link
Collaborator

  • On release, use the release tag
  • On non-release CI runs, fetch latest tag and use that
    • No need to hardcode version in the CI workflow for non-release builds
  • In addition, enable container build on all builds
    • Enable push only on release
  • Resolves Add version.h to store the released version #87

Signed-off-by: Azeem Sajid [email protected]

@iamazeem iamazeem added the enhancement New feature or request label Oct 13, 2024
@iamazeem iamazeem self-assigned this Oct 13, 2024
@iamazeem iamazeem requested a review from liquidaty October 13, 2024 07:58
@iamazeem iamazeem merged commit a3d3fac into main Oct 13, 2024
7 checks passed
@iamazeem iamazeem deleted the 87-version branch October 13, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liquidaty liquidaty Awaiting requested review from liquidaty

Assignees

@iamazeem iamazeem

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add version.h to store the released version
1 participant
@iamazeem