Fix SQLite3 include path for compare
command
#202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment
Description
Makefile
was not using the SQLite3 headers from theexternal
libs directory.Affected failing tests:
test-compare
test-compare-tolerance
Steps to reproduce
Make sure the SQLite3 dev packages are not preinstalled on the system.
For example, on Ubuntu, check if
sqlite3.h
is present e.g.whereis sqlite3.h
.If it exists, uninstall it i.e.
sudo apt remove -y libsqlite3-dev
.Run:
cd app/test make test-compare make test-compare-tolerance
Error:
On the configured Ubuntu runner i.e. Ubuntu 20.04, the package
libsqlite3-dev
is preinstalled.That's why it was undetected so far.
Same was the case on my local machine.
Verified by uninstalling the
libsqlite3-dev
previously installed viaapt
package.Signed-off-by: Azeem Sajid [email protected]