Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQLite3 include path for compare command #202

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

iamazeem
Copy link
Collaborator

@iamazeem iamazeem commented Oct 3, 2024

Environment

Description

Makefile was not using the SQLite3 headers from the external libs directory.

Affected failing tests:

  • test-compare
  • test-compare-tolerance

Steps to reproduce

Make sure the SQLite3 dev packages are not preinstalled on the system.
For example, on Ubuntu, check if sqlite3.h is present e.g. whereis sqlite3.h.
If it exists, uninstall it i.e. sudo apt remove -y libsqlite3-dev.

Run:

cd app/test
make test-compare
make test-compare-tolerance

Error:

compare.c:17:10: fatal error: sqlite3.h: No such file or directory
   17 | #include <sqlite3.h>
      |          ^~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:442: ~/zsv/build/Linux/rel/gcc/bin/zsv_compare] Error 1
make[1]: Leaving directory '~/zsv/app'
make: *** [Makefile:438: ~/zsv/build/Linux/rel/gcc/bin/zsv_compare] Error 2

On the configured Ubuntu runner i.e. Ubuntu 20.04, the package libsqlite3-dev is preinstalled.
That's why it was undetected so far.

Same was the case on my local machine.
Verified by uninstalling the libsqlite3-dev previously installed via apt package.

Signed-off-by: Azeem Sajid [email protected]

@iamazeem iamazeem added the bug Something isn't working label Oct 3, 2024
@iamazeem iamazeem self-assigned this Oct 3, 2024
@iamazeem iamazeem requested a review from liquidaty October 3, 2024 06:57
@iamazeem iamazeem merged commit 1b4b8a9 into main Oct 3, 2024
6 checks passed
@iamazeem iamazeem deleted the fix-sqlite3-include-path-for-compare branch October 3, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant