Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with correct Chocolatey installation instructions #176

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

anyavaish
Copy link
Contributor

Previous installation in README.md for Windows using choco.exe changed so it points at directory .nupkg file is in, not at the .nupkg file itself

README.md Outdated
@@ -160,7 +160,7 @@ For Windows (`*.nupkg`), install with `choco.exe`:

```shell
# Install
choco.exe install zsv --pre -source .\zsv-amd64-windows-mingw.nupkg
choco.exe install zsv --pre -source .

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on doing something like <directory containing .nupkg file>? Otherwise I'm not sure if . implies that much

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think changing it to that makes sense.

@anyavaish
Copy link
Contributor Author

@kevin-zou-lq I have implemented the changes you suggested. Please review.

@kevin-zou-lq
Copy link

@kevin-zou-lq I have implemented the changes you suggested. Please review.

Great, thank you!

@anyavaish anyavaish requested a review from kevin-zou-lq July 2, 2024 18:05
@liquidaty liquidaty merged commit 66fa839 into liquidaty:main Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants