Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: multiple mock matching #99

Merged

Conversation

xneomac
Copy link
Contributor

@xneomac xneomac commented Jan 13, 2020

This is an implementation proposal of the feature previously discussed in issue #97.

The idea is to detect if there is multiple mock matching the same request and calling them while the number of request expected is not reached. When it is reached we call the next one. If there is no more available we keep calling the last one.

@lipanski
Copy link
Owner

@xneomac can you please rebase this branch? I merged your other PR into master and fixed both Travis and Appveyor.

@Jonathas-Conceicao
Copy link

Any updates on this?

I think this is a nice feature to have, certainly makes mocks more flexible to design. I would like to see this merged.

I have forked and rebased the commit from @xneomac so I could use for my tests in the mean time (could't build the original fork as is). And it seams to work as intended.

@lipanski lipanski merged commit 7bb0b8d into lipanski:master Apr 5, 2020
@lipanski
Copy link
Owner

lipanski commented Apr 5, 2020

@Jonathas-Conceicao released with 0.25.0. Thanks for your effort and thanks to @xneomac for building the feature 🥇

@lipanski
Copy link
Owner

lipanski commented Apr 8, 2020

Fixed a small bug with 96f3e30 and released in 0.25.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants