Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build of wheels for python 3.8 #140

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Build of wheels for python 3.8 #140

merged 1 commit into from
Jan 22, 2025

Conversation

FatsieFS
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Jan 20, 2025

A preview of is uploaded and can be seen here:

https://lip6.github.io/coriolis/pull/140/

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/lip6/coriolis/tree/gh-pages/pull/140/

@FatsieFS
Copy link
Collaborator Author

MACOS builds are failing. I don't see why this change should cause that.

@jpc-lip6
Copy link
Collaborator

The failure under MacOS has already been fixed, but in branch ihp-fix. I would like to work a bit more on it before merging it with main, that is adding a C++ flexible BigVia feature, but maybe that's a mistake and I should merge now. What do you think ?

@FatsieFS
Copy link
Collaborator Author

FatsieFS commented Jan 21, 2025

I think it is good practice to keep main branch CI working. Wether that means merging the ihp-fix branch or just backporting the MACOS build fix to main, I leave that up to you.

@jpc-lip6 jpc-lip6 merged commit b24c0cc into main Jan 22, 2025
9 of 14 checks passed
@jpc-lip6 jpc-lip6 deleted the staf/cp38 branch January 22, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants