Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: concurrency file order TDE-1213 #998

Merged
merged 8 commits into from
Jul 15, 2024

Conversation

amfage
Copy link
Contributor

@amfage amfage commented Jul 8, 2024

Motivation

When supplying multiple source locations to use for standardising, if there are overlapping source images, the VRT created does not honour the priority order for the supplied datasets. This Pull Request is to retain the priority of the images for merging.

Modification

Move away from using as_completed for parallel processing so that the output file list is in the same order as the input file list.

Checklist

If not applicable, provide explanation of why.

  • Tests updated
  • Docs updated
  • Issue linked in Title

scripts/files/fs.py Outdated Show resolved Hide resolved
@amfage amfage marked this pull request as ready for review July 11, 2024 23:49
@amfage amfage requested a review from a team as a code owner July 11, 2024 23:49
blacha
blacha previously approved these changes Jul 12, 2024
@amfage amfage requested review from blacha and dwsilk July 12, 2024 02:03
@dwsilk dwsilk added this pull request to the merge queue Jul 15, 2024
Merged via the queue into master with commit 37dcb8b Jul 15, 2024
2 checks passed
@dwsilk dwsilk deleted the fix/concurrency-file-order-tde-1213 branch July 15, 2024 21:43
@github-actions github-actions bot mentioned this pull request Jul 15, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 16, 2024
🤖 I have created a release *beep* *boop*
---


## [4.9.0](v4.8.0...v4.9.0)
(2024-07-16)


### Features

* Add Shapely type library TDE-1205
([#988](#988))
([f5e97e7](f5e97e7))
* use new pull request template
([#999](#999))
([9a6a0b2](9a6a0b2))


### Bug Fixes

* concurrency file order TDE-1213
([#998](#998))
([37dcb8b](37dcb8b))
* Treat item as `dict` TDE-1209
([#993](#993))
([384d0fc](384d0fc))


### Reverts

* Pull Requests [#993](#993)
and [#985](#985)
([#997](#997))
([289880c](289880c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants