Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update wording for release #878

Merged
merged 2 commits into from
Feb 27, 2024
Merged

fix: update wording for release #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc9c670
test: update for dem/dsm description wording
amfage Feb 27, 2024
adefc65
fix: update wording to force a release
amfage Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions scripts/stac/imagery/collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,11 +334,11 @@ def _title(self) -> str:
def _description(self) -> str:
"""Generates the descriptions for imagery and elevation datasets.
Urban Aerial Photos / Rural Aerial Photos:
Orthophotography within the [Region] region captured in the [Year(s)] flying season.
Orthophotography within the [Region] region captured in the [year(s)] flying season.
DEM / DSM:
[Digital Surface Model / Digital Elevation Model] within the [Region] region in [year(s)].
[Digital Surface Model / Digital Elevation Model] within the [Region] region captured in [year(s)].
Satellite Imagery / Scanned Aerial Photos:
[Satellite imagery | Scanned Aerial Photos] within the [Region] region captured in [Year(s)].
[Satellite imagery | Scanned Aerial Photos] within the [Region] region captured in [year(s)].

Returns:
Dataset Description
Expand All @@ -358,9 +358,9 @@ def _description(self) -> str:
elif self.metadata["category"] in [URBAN_AERIAL_PHOTOS, RURAL_AERIAL_PHOTOS]:
desc = f"Orthophotography within the {region} region captured in the {date} flying season"
elif self.metadata["category"] == DEM:
desc = f"Digital Elevation Model within the {region} region in {date}"
desc = f"Digital Elevation Model within the {region} region captured in {date}"
elif self.metadata["category"] == DSM:
desc = f"Digital Surface Model within the {region} region in {date}"
desc = f"Digital Surface Model within the {region} region captured in {date}"
else:
raise SubtypeParameterError(self.metadata["category"])

Expand Down
4 changes: 2 additions & 2 deletions scripts/stac/imagery/tests/generate_description_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def test_generate_description_elevation(metadata: Tuple[CollectionMetadata, Coll
metadata_auck, _ = metadata
metadata_auck["category"] = "dem"
collection = ImageryCollection(metadata_auck)
description = "Digital Elevation Model within the Auckland region in 2023."
description = "Digital Elevation Model within the Auckland region captured in 2023."
assert collection.stac["description"] == description


Expand All @@ -57,7 +57,7 @@ def test_generate_description_elevation_geographic_description_input(
metadata_auck["category"] = "dem"
metadata_auck["geographic_description"] = "Central"
collection = ImageryCollection(metadata_auck)
description = "Digital Elevation Model within the Auckland region in 2023."
description = "Digital Elevation Model within the Auckland region captured in 2023."
assert collection.stac["description"] == description


Expand Down
Loading