Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: logs hostname and execution time TDE-431 #77

Merged
merged 7 commits into from
Aug 11, 2022
Merged

feat: logs hostname and execution time TDE-431 #77

merged 7 commits into from
Aug 11, 2022

Conversation

paulfouquet
Copy link
Collaborator

@paulfouquet paulfouquet commented Aug 3, 2022 •
edited
Loading

Description

To facilitate logs investiation, having a unique ID as hostname and a duration for the scripts execution will help.

Changes

  • Upgrade python_linz_logger to v0.9.0 to get hostname as a default key.
  • Capture the execution time (duration) and log it.

Tests

The execution time has been tested locally. Getting the Argo node ID has been tested using the test.yaml Workflow.

@paulfouquet paulfouquet requested a review from a team as a code owner August 3, 2022 02:49
blacha
blacha reviewed Aug 3, 2022
View reviewed changes
scripts/create_polygons.py Outdated Show resolved Hide resolved
@paulfouquet paulfouquet changed the title feat: log argo node id (pod_name) and execution time feat: log argo node id (pod_name) and execution time TDE-431 Aug 7, 2022
@paulfouquet paulfouquet changed the title feat: log argo node id (pod_name) and execution time TDE-431 feat: logs hostname and execution time TDE-431 Aug 7, 2022
@paulfouquet paulfouquet marked this pull request as draft August 8, 2022 22:54
@paulfouquet paulfouquet marked this pull request as ready for review August 9, 2022 02:36
@paulfouquet paulfouquet added enhancement New feature or request automerge 🚀 python Pull requests that update Python code labels Aug 9, 2022
@paulfouquet paulfouquet self-assigned this Aug 9, 2022
@kodiakhq kodiakhq bot merged commit abb6634 into master Aug 11, 2022
@kodiakhq kodiakhq bot deleted the feat/tde-431-log-argo-node-id branch August 11, 2022 03:09
@github-actions github-actions bot mentioned this pull request Aug 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacha blacha blacha approved these changes

@amfage amfage Awaiting requested review from amfage amfage is a code owner automatically assigned from linz/li-topo-data-engineering

@MDavidson17 MDavidson17 Awaiting requested review from MDavidson17 MDavidson17 is a code owner automatically assigned from linz/li-topo-data-engineering

Assignees

@paulfouquet paulfouquet

Labels
enhancement New feature or request python Pull requests that update Python code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulfouquet @blacha