Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deploy containers to ecr TDE-689 #408

Merged
merged 8 commits into from
Mar 27, 2023
Merged

feat: deploy containers to ecr TDE-689 #408

merged 8 commits into from
Mar 27, 2023

Conversation

MDavidson17
Copy link
Contributor

@MDavidson17 MDavidson17 commented Mar 22, 2023 •
edited
Loading

Follows the guidelines here: https://github.com/aws-actions/amazon-ecr-login#building-and-pushing-an-image

Considerations:

Cost: https://aws.amazon.com/ecr/pricing/
In particular - storage: $0.10 per GB /Month

Lifecylce: https://docs.aws.amazon.com/AmazonECR/latest/userguide/LifecyclePolicies.html

Screenshots from test deployments:

Branch: test/aws-configure
First Deployment:
Screenshot from 2023-03-24 09-50-41
Second Deployment (after update to topo-imagery):
Screenshot from 2023-03-24 09-51-24

@MDavidson17 MDavidson17 force-pushed the feat/deploy-containers-to-ecr branch from 41e6a96 to 2ebdf0c Compare March 23, 2023 22:20
@MDavidson17 MDavidson17 marked this pull request as ready for review March 23, 2023 22:33
@MDavidson17 MDavidson17 requested a review from a team as a code owner March 23, 2023 22:33
paulfouquet
paulfouquet reviewed Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@paulfouquet paulfouquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful information in the description.
Just a couple of comments (optional), look good to me otherwise

.github/workflows/release-please.yml Outdated Show resolved Hide resolved
.github/workflows/containers.yml Outdated Show resolved Hide resolved
amfage
amfage previously approved these changes Mar 24, 2023
View reviewed changes
@kodiakhq kodiakhq bot merged commit 31c713c into master Mar 27, 2023
@kodiakhq kodiakhq bot deleted the feat/deploy-containers-to-ecr branch March 27, 2023 00:04
@github-actions github-actions bot mentioned this pull request Mar 27, 2023
Merged
@MDavidson17 MDavidson17 mentioned this pull request Mar 30, 2023
Merged
blacha pushed a commit to linz/argo-tasks that referenced this pull request Apr 2, 2023
@MDavidson17 @paulfouquet
ci: publish containers to ECR TDE-705 (#336)
71a012d 
https://github.com/aws-actions/amazon-ecr-login#examples-of-usage

linz/topo-imagery#408
linz/topo-imagery#415

---------

Co-authored-by: paulfouquet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfouquet paulfouquet paulfouquet approved these changes

@blacha blacha Awaiting requested review from blacha blacha is a code owner automatically assigned from linz/li-topo-data-engineering

@amfage amfage Awaiting requested review from amfage

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MDavidson17 @amfage @paulfouquet