Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create collection TDE-453 #177

Merged
merged 6 commits into from
Oct 25, 2022
Merged

feat: create collection TDE-453 #177

merged 6 commits into from
Oct 25, 2022

Conversation

MDavidson17
Copy link
Contributor

@MDavidson17 MDavidson17 commented Oct 14, 2022

arg desc user input required?
--uri path to items & write location of collection.json no, s3://..../flat/
--collection_id ulid no, output of generate_ulid
--title collection title yes
--description collection description yes

note: there is currently no validation of --title, in future, this may need to be added if the title is going to be used to determine the publish path.

@MDavidson17 MDavidson17 marked this pull request as ready for review October 25, 2022 00:56
@MDavidson17 MDavidson17 requested a review from a team as a code owner October 25, 2022 00:56
@kodiakhq kodiakhq bot merged commit 20f5f34 into master Oct 25, 2022
@kodiakhq kodiakhq bot deleted the feat/create-collection branch October 25, 2022 21:36
@github-actions github-actions bot mentioned this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants