Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use boto3 clients rather than resources TDE-1034 #1172

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor: Use boto3 clients rather than resources TDE-1034 #1172

wants to merge 3 commits into from
+118 −117

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Nov 15, 2024

Motivation

The latter is deprecated
https://boto3.amazonaws.com/v1/documentation/api/1.35.60/guide/resources.html.

Modifications

  • Use the lower-level clients API instead of resources.
  • Type annotate S3 clients to make IDE use easier.

Verification

Standard tests.

@l0b0 l0b0 requested a review from a team as a code owner November 15, 2024 03:02
@l0b0 l0b0 enabled auto-merge November 15, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmidtnz schmidtnz Awaiting requested review from schmidtnz schmidtnz is a code owner automatically assigned from linz/li-topo-data-engineering

@amfage amfage Awaiting requested review from amfage amfage is a code owner automatically assigned from linz/li-topo-data-engineering

@MDavidson17 MDavidson17 Awaiting requested review from MDavidson17 MDavidson17 is a code owner automatically assigned from linz/li-topo-data-engineering

@paulfouquet paulfouquet Awaiting requested review from paulfouquet paulfouquet is a code owner automatically assigned from linz/li-topo-data-engineering

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@l0b0