fix: always ignore existing overviews TDE-1046 (#862)

* fix: always ignore existing overviews TDE-1046 * docs: add explanation
linz · Feb 19, 2024 · 900907f · 900907f
1 parent 3e550af
commit 900907f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/scripts/gdal/gdal_preset.py b/scripts/gdal/gdal_preset.py
@@ -31,6 +31,9 @@
     # An error will be raise by GDAL if it fails creating a tiff > 4GB in size
     "-co",
     "bigtiff=no",
+    # Always ignore existing overviews so they are not created from already compressed overviews
+    "-co",
+    "overviews=ignore_existing",
 ]
 
 DEM_LERC = [
@@ -60,7 +63,7 @@
 ]
 
 COMPRESS_WEBP_LOSSLESS = [
-    # Comppress into webp
+    # Compress into webp
     "-co",
     "compress=webp",
     # Compress losslessly
@@ -79,8 +82,6 @@
     # Reduce quality of overviews to 90%
     "-co",
     "overview_quality=90",
-    "-co",
-    "overviews=ignore_existing",
 ]
 
 

diff --git a/scripts/gdal/tests/gdal_preset_test.py b/scripts/gdal/tests/gdal_preset_test.py
@@ -31,6 +31,7 @@ def test_preset_lzw() -> None:
     assert "blocksize=512" in gdal_command
     assert "num_threads=all_cpus" in gdal_command
     assert "bigtiff=no" in gdal_command
+    assert "overviews=ignore_existing" in gdal_command
 
     # LZW compression
     assert "compress=lzw" in gdal_command
@@ -40,7 +41,6 @@ def test_preset_lzw() -> None:
     assert "overview_compress=webp" in gdal_command
     assert "overview_resampling=lanczos" in gdal_command
     assert "overview_quality=90" in gdal_command
-    assert "overviews=ignore_existing" in gdal_command
 
     assert "EPSG:2193" in gdal_command
 
@@ -52,6 +52,7 @@ def test_preset_dem_lerc() -> None:
     assert "blocksize=512" in gdal_command
     assert "num_threads=all_cpus" in gdal_command
     assert "bigtiff=no" in gdal_command
+    assert "overviews=ignore_existing" in gdal_command
 
     # LERC compression
     assert "compress=lerc" in gdal_command
@@ -62,7 +63,6 @@ def test_preset_dem_lerc() -> None:
     assert "overview_compress=webp" not in gdal_command
     assert "overview_resampling=lanczos" not in gdal_command
     assert "overview_quality=90" not in gdal_command
-    assert "overviews=ignore_existing" not in gdal_command
 
     assert "EPSG:2193" in gdal_command