Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gestures: Allow the user to specify which phase of a gesture should trigger its action. #11880

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

mtwebster
Copy link
Member

@anaximeno
Copy link
Contributor

The 2 and 5 fingers options are being shown in the gesture swipe settings even if the screen does not support it, is this expected now?

Also, I've to confess that there are quite a number of configuration options in this module:

2023-10-06.23-19-14.mp4

I wonder if it would be better to bind that configuration to trigger at the start or the end, generally, to the swipe and pinch gestures or at least make that an option you choose for the swipe or pinch based on the number of fingers in general (like for the three fingers swipe you can choose for it to trigger at the start, but for the four fingers swipe, at the end). I probably would not have a reason to tune each specific action but, I am not against how this is implemented right now since someone might benefit from that, but I still believe it's a lot of settings for one section.

But, after all, it can be a bit more fluid by having some gestures set to trigger at the start. So this is a good update on gestures.

@mtwebster
Copy link
Member Author

Added desktop zoom support.

I made it so the phase combobox disappears if it's not applicable for its gesture type - if it's 'Disabled' or one of the types that forbid changing it (for now, zoom, volume changes only).

@igarca
Copy link

igarca commented Oct 20, 2023

Can't believe pinch-to-zoom is here.
Thank you very much!!!
Just some comments:

  1. It zooms in/out at a low rate, so you need to pinch two or three times to zoom in as desired (since you run out of space on the touchpad). I think it would be helpful to implement an option to increase the "zoom ratio", so that without lifting your fingers from the touchpad, with a single pinch, you can zoom in and out.
  2. Unfortunately I can't use a "custom command" as the box to input the command dissapeared: https://i.imgur.com/dN4jIsZ.png

@mtwebster
Copy link
Member Author

I'll have a look at the custom command and making the zoom rate configurable (I sort of figured this would be needed anyhow), thanks.

- Allow actions to be exectured either at the beginning or end of
  the gesture.  Rework gesture settings to accomodate this in the
  ui.
- Rework gsettings storage format to more easily allow future
  expansion. (with migration)
- Implement a range-adjust widget for actions that might benefit
  from it (nothing uses it for now).

ref: https://github.com/orgs/linuxmint/discussions/102
This action requires the desktop-zoom accessibility feature to be
enabled.

The sensitivity of the action is adjustable to control the
magnification change for a given amount of gesture distance.
@mtwebster mtwebster merged commit 861b2ed into linuxmint:master Nov 20, 2023
2 checks passed
@floccus101
Copy link

Hi.
I installed Linux Mint a weeks ago and missed the touchpad-pinch-zoom that I used in Windows 10 browsers.
After searching for hours I found this conversation.

In the default gestures app there is "swipe", "pinch" and "settings". In the pinch-tab (under pinch with 2 fingers) is unfortunately no zoom option.

The commit of mtwebster should have added this.

I have followed the instructions of mtwebster to enable the debug-mode for gestures.
And I also enabled the desktop-zoom accessibility feature, but the zoom-function did not appear.

Now my questions that came up:

  1. Should the zoom function have been there by default (i.e. without any changes)?
  2. If no: Is there a manual that explains how to get this function?
  3. Do I need to pull something or manually change some files? If yes, please give me instructions.
  4. Is it possible that my device thinks this is feature is not compatible? Could I turn this off?

I would be very grateful for answers.

specs:
Linux Mint 21.2 Cinnamon
Cinnamon 5.8.4
Kernel: 5.15.0-91-generic

@anaximeno
Copy link
Contributor

@floccus101 this feature will be available in the next version of Mint 21.3 which is almost ending beta testing and might be released in the following weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants