-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update kubernetes #92
base: master
Are you sure you want to change the base?
Conversation
Also enable external storage provisioners like Ceph RBD. Added eudev needed for detecting device mounts. Without it tools like rbd will timeout waiting for a message on /run/udev/control. Signed-off-by: Bastiaan Schaap <[email protected]>
This contains a working eudev package as well (linuxkit/linuxkit#2836) |
@@ -1,4 +1,4 @@ | |||
FROM linuxkit/alpine:1b05307ae8152e3d38f79e297b0632697a30c65c AS build | |||
FROM linuxkit/alpine:08c8d8aa3638d035e18499a74faf50eedb8d6cf6-amd64 AS build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why lock it to amd64
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not done on purpose. I built a new linuxkit/alpine
3.10 base image (mirror), which I need to use as base. So it's just a quick copy-and-paste from my docker build output...
I guess all image hashed would need to be corrected, since there will be new ones once the upstream image gets built, signed and pushed by a Docker employee.
I won't have a chance to review properly (and test) for a few days yet, but my first thoughts:
|
Also CI is failing. |
@deitch You are right. I'll work through these, as I just built and ran this locally without any concerns for actually pushing it (which I originally hadn't planned). I'll do my best to get the PR up to a better standard. Just did the PR already for now to get feedback/input from you ;-) |
Thanks @bjwschaap ! |
Please sign your commits following these rules: $ git clone -b "upgrade" [email protected]:bjwschaap/kubernetes.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354609448
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Bastiaan Schaap <[email protected]>
Signed-off-by: Bastiaan Schaap <[email protected]>
@deitch Did you get a chance to look into this PR yet? I'm pretty much stuck at this point, since in order to build the packages, an Alpine 3.10 image from linuxkit/linuxkit#3388 is needed. |
Also enable external storage provisioners like Ceph RBD.
Added eudev needed for detecting device mounts. Without it tools like
rbd will timeout waiting for a message on /run/udev/control.
Signed-off-by: Bastiaan Schaap [email protected]