-
Notifications
You must be signed in to change notification settings - Fork 76
Build cni and cri tools #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
78782ac to
455e618
Compare
| musl \ | ||
| openssl \ | ||
| socat \ | ||
| util-linux \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure we can get rid of libc6-compat now, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't remember what it was needed for (maybe it was even cargo-culted from somewhere else and never useful here). If someone wants to remove it and test the result that would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilj it was needed to run Kubernetes release binaries, it's not needed since we build here, although I don't know about the CNI binaries, but that's not a question as of this PR. I've put it there in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes, it's probably useless then.
I'll try and pin a commit on here before I head off for vacation then!
Signed-off-by: Ian Campbell <[email protected]>
This can be used to interact with the CRI provider and kubeadm can use it for some things too it seems (judging from the logging from `kubeadm init`). Include critest too since it is built. Signed-off-by: Ian Campbell <[email protected]>
Remind the reader about the other place to update. Structured as a list because I'm anticipating linuxkit#35 adding another. Make the variable name consistent too by updating scripts/mk-image-cache-lst. Signed-off-by: Ian Campbell <[email protected]>
This was needed when we used the binaries built/released by the Kube project, but since we build everything ourselves in an Alpine environment there is no need now. Signed-off-by: Ian Campbell <[email protected]>
455e618 to
054a553
Compare
|
ping @rn / @justincormack |
rn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be wrong if I'd claim I fully understand this PR but the mechanics look good to me
Build CNI binaries ourselves rather than shipping prebuilt binaries.
Add the cri tool binaries (
crictlandcritest) also built from source.Add a comment next to both definitions of
kubernetes_versioncross-referencing the other for updates (should incorporate #35 at some point too).