Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing default windowRadius #290

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

18202781743
Copy link
Contributor

as title.

pms: BUG-291123

as title.

pms: BUG-291123
@18202781743 18202781743 requested a review from mhduiy December 13, 2024 07:18
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • windowRadius 函数的签名已更改,增加了默认参数,但未更新函数文档和调用处。
  • windowRadius 函数的返回值从空值改为 -1,需要确认这是否符合业务逻辑。

是否建议立即修改:

  • 是,需要确保函数签名的更改与文档和调用代码保持一致。
  • 是,需要验证返回 -1 的逻辑是否符合预期业务需求。

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 13, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#290
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit df15974 into linuxdeepin:master Dec 13, 2024
22 of 24 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 13, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants