fix: icon doesn't update when iconTheme changed #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18202781743
requested review from
FeiWang1119,
kegechen,
BLumia,
asterwyx and
zccrs
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Jan 22, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#221
18202781743
added a commit
to 18202781743/dtkdeclarative
that referenced
this pull request
Jan 22, 2024
Adding iconTheme to it's url, `QQuickImageBase` has a cache store, and Url as a part of the key. it depends on linuxdeepin/dtkgui#221.
|
Doc Check bot |
18202781743
force-pushed
the
icon-update
branch
from
dbd6b9e to
84ab779
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Jan 23, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#221
18202781743
added a commit
to 18202781743/dtkdeclarative
that referenced
this pull request
Jan 23, 2024
Adding iconTheme to it's url, `QQuickImageBase` has a cache store, and Url as a part of the key. it depends on linuxdeepin/dtkgui#221.
18202781743
added a commit
to 18202781743/dtkdeclarative
that referenced
this pull request
Jan 23, 2024
Adding iconTheme to it's url, `QQuickImageBase` has a cache store, and Url as a part of the key. it depends on linuxdeepin/dtkgui#221.
18202781743
added a commit
to 18202781743/dtkdeclarative
that referenced
this pull request
Jan 23, 2024
Adding iconTheme to it's url, `QQuickImageBase` has a cache store, and Url as a part of the key. it depends on linuxdeepin/dtkgui#221.
18202781743
added a commit
to 18202781743/dtkdeclarative
that referenced
this pull request
Jan 23, 2024
Adding iconTheme to it's url, `QQuickImageBase` has a cache store, and Url as a part of the key. it depends on linuxdeepin/dtkgui#221.
FeiWang1119
previously approved these changes
Jan 23, 2024
asterwyx
requested changes
Jan 23, 2024
18202781743
added a commit
to linuxdeepin/dtkdeclarative
that referenced
this pull request
Jan 23, 2024
Adding iconTheme to it's url, `QQuickImageBase` has a cache store, and Url as a part of the key. it depends on linuxdeepin/dtkgui#221.
Adding icon's themeName as a part of the cache key.
18202781743
force-pushed
the
icon-update
branch
from
84ab779 to
dc57298
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Jan 23, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#221
BLumia
approved these changes
Jan 23, 2024
asterwyx
approved these changes
Jan 23, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, asterwyx, BLumia The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
18202781743
pushed a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Jan 23, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding icon's themeName as a part of the cache key.