Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Add a necessary comment #393

Merged
merged 1 commit into from
Sep 6, 2024
Merged

style: Add a necessary comment #393

merged 1 commit into from
Sep 6, 2024

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Sep 5, 2024

as title

Log:

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Sep 5, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#393
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 5, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 在新增的注释中,应该更详细地解释为什么要禁用抗锯齿,以及这可能会导致哪些具体的问题。
  • 确认新增的注释是否应该使用英文,因为Qt的代码库中使用的是英文注释。

是否建议立即修改:

  • 是,应该立即修改注释,使其更加清晰易懂,并且考虑使用英文注释以保持代码库的一致性。

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Sep 6, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#393
@mhduiy mhduiy changed the title style: Add necessary code annotations style: Add a necessary comment Sep 6, 2024
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit 04baea7 into linuxdeepin:master Sep 6, 2024
16 of 17 checks passed
mhduiy pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Sep 6, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants