Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Combobox shadow is cliped #392

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Sep 5, 2024

remove clip property

Log:

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Sep 5, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#392
remove clip property

Log:
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Sep 5, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#392
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • ComboBox.qml文件中,popupclip属性被设置为true,这可能会导致弹出窗口的裁剪问题。通常,如果implicitWidthmaxVisibleItems的值没有设置,ArrowListView可能会尝试适应其父元素的尺寸,这可能导致不正确的裁剪。建议检查implicitWidthmaxVisibleItems的设置,确保它们能够正确地反映弹出窗口的预期尺寸。
  • ComboBox.qml文件中,ArrowListViewmaxVisibleItems属性被设置为control.maxVisibleItems,这可能会导致性能问题,因为每次maxVisibleItems的值发生变化时,都会触发视图的重绘。建议检查maxVisibleItems的值是否经常变化,如果变化频繁,可以考虑使用信号和槽机制来更新视图,而不是每次都触发重绘。
  • ComboBox.qml文件中,ArrowListViewview.model属性被设置为control.delegateModel,这可能会导致与现有QML框架不兼容的问题。建议检查control.delegateModel的来源和类型,确保它与ArrowListView的预期模型兼容。
  • ComboBox.qml文件中,ArrowListViewview.currentIndex属性被设置为control.highlightedIndex,这可能会导致与现有QML框架不兼容的问题。建议检查control.highlightedIndex的来源和类型,确保它与ArrowListView的预期模型兼容。

是否建议立即修改:

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 5, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit 8cb5678 into linuxdeepin:master Sep 5, 2024
20 of 21 checks passed
mhduiy pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Sep 5, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants