Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crashed on floatingmessage closed #378

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

kegechen
Copy link
Contributor

@kegechen kegechen commented Aug 15, 2024

  • partially cherry-pick from waylib
  • remove TextureChangedCallback when DQuickBackdropBlitter destroyed...

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 15, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#378
@kegechen kegechen requested a review from zccrs August 15, 2024 07:39
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 15, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cherry-pick from waylib#436
invalid BlitTextureProvider pointer
@kegechen kegechen merged commit c2a17b4 into linuxdeepin:dev/animation Aug 19, 2024
15 of 20 checks passed
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 19, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#378
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • resolve函数中,使用了std::weak_ptr来处理数据列表,这是一个好的做法,因为它避免了潜在的内存泄漏。
  • tryClean函数被移除,但cleanJob变量被重命名为cleanJob,这可能会导致混淆。建议保持原有的命名风格,或者如果移除是故意的,应该在代码中添加相应的注释说明。
  • release函数中增加了对data是否为nullptr的检查,这是一个好的安全措施,可以防止在尝试访问data成员时出现未定义行为。
  • ensureCleanJob函数中,使用了Q_LIKELY宏来优化条件判断,这是一个好的性能优化技巧。
  • texture.reset()被移除,但image.reset()被保留,这可能会导致不一致的行为。建议保持代码的一致性和清晰性,或者添加注释说明为什么移除texture.reset()
  • cleanTextureProvider函数被添加,但没有提供相关的注释说明其用途和功能。建议添加适当的注释来帮助其他开发者理解代码的意图。
  • BlitTextureProviderensureTextureProvider函数中,移除了对textureChanged信号的处理,这可能会影响其他依赖此信号的功能。建议评估这一变更的影响,并确保相关功能得到妥善处理。

是否建议立即修改:

  • 需要确保代码的一致性和清晰性,避免潜在的混淆和错误。
  • 添加必要的注释来帮助其他开发者理解代码的意图和功能。
  • 评估并处理可能影响现有功能和预期的变更。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants