Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the display size of dci icon is exceptional #376

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

FeiWang1119
Copy link
Contributor

The size of dci icon becomes larger than before when updating the interface under the dpi > 1.0

Log:

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 14, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#376
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 14, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#376
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 14, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

The size of dci icon becomes larger than before when updating the interface under the dpi > 1.0

Log:
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 15, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#376
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • D.DciIcon元素中新增了mode, theme, palette, sourceSize属性,需要确认这些属性的添加是否符合设计需求和组件的预期行为。
  • rotation属性的值根据root.isExpanded的值动态变化,这可能是一个功能性的改变,但需要确保这个逻辑的正确性和可维护性。
  • Layout.preferredWidthLayout.preferredHeight属性被移除,如果这些大小是根据其他因素动态计算的,这可能会影响布局的预期行为。

是否建议立即修改:

  • 是,需要确保新增属性的添加是有意义的,并且不会对现有功能产生负面影响。
  • 是,需要验证rotation属性的逻辑是否正确,并且是否有必要进行这样的动态变化。
  • 是,如果移除Layout.preferredWidthLayout.preferredHeight会影响布局的预期行为,那么应该立即修复或提供替代方案。

@FeiWang1119 FeiWang1119 merged commit 3318a32 into linuxdeepin:dev/animation Aug 16, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants