Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can't move dialog window #374

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

FeiWang1119
Copy link
Contributor

change Control to Item, as Control do not let clicks and touches through to items below them.

Issue: linuxdeepin/dtk#190

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 9, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#374
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 9, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 12, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#374
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 12, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#374
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 13, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#374
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 13, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#374
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 14, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#374
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, FeiWang1119

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

change Control to Item, as Control do not let clicks and touches through to items below them.

Issue: linuxdeepin/dtk#190
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 14, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#374
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • DialogTitleBar.qml中,Item替换为Control可能会影响布局和行为,需要确认是否有特定的设计意图。
  • DialogTitleBar.qml中,anchors.fill: parent的添加可能会导致子控件的大小超过父控件,需要确保这是预期的行为。
  • DialogTitleBar.qml中,D.InWindowBlur的直接使用可能会绕过QML的属性绑定,需要确认这是否是预期的用法。
  • DialogTitleBar.qml中,contentItem的布局属性anchors.fill: parent可能会导致子控件的大小超过父控件,需要确保这是预期的行为。
  • DialogWindow.qml中,Window替换为Item可能会影响窗口的显示和行为,需要确认是否有特定的设计意图。
  • DialogWindow.qml中,implicitHeight: childrenRect.height的使用可能会导致窗口高度的计算出现问题,需要确保这是预期的行为。

是否建议立即修改:

@FeiWang1119 FeiWang1119 merged commit 442999f into linuxdeepin:master Aug 14, 2024
17 of 21 checks passed
mhduiy pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 21, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants