Listview hover #373
Merged
Listview hover #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kegechen
commented
Aug 9, 2024
•
kegechen
commented
- hover background color tweak
- avoid warnning
- fix drag item image pixelated
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kegechen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Aug 9, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#373
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Aug 9, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#373
|
Doc Check bot |
18202781743
reviewed
Aug 12, 2024
| NumberAnimation { target: backgroundPanel; property: "y"; to: btnGroup.checkedButton.y; duration: 200 } | ||
| NumberAnimation { target: backgroundPanel; property: "width"; to: btnGroup.checkedButton.width; duration: 200 } | ||
| NumberAnimation { target: backgroundPanel; property: "height"; to: btnGroup.checkedButton.height; duration: 200 } | ||
| NumberAnimation { target: backgroundPanel; property: "x"; to: btnGroup.checkedButton ? btnGroup.checkedButton.x : backgroundPanel.x; duration: 200 } |
There was a problem hiding this comment.
这个不会有循环绑定么?当btnGroup.checkedButton为null时, target: backgroundPanel的x 被赋值为 backgroundPanel.x,
light: #000000 %10 dark: #ffffff %10
read property from null
image size == item size
kegechen
force-pushed
the
listview_hover
branch
from
6ef6ba2
to
df068ba
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Aug 15, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#373
deepin pr auto review关键摘要:
是否建议立即修改: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.