Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch animation tweak #372

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

kegechen
Copy link
Contributor

@kegechen kegechen commented Aug 9, 2024

remove static dci icon

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 9, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#372
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 9, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

remove static dci icon
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 9, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#372
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • Switch.qml文件中,name属性的计算逻辑从基于control.checked的状态转换为直接比较control.checked!control.checked,这可能会改变开关的状态。
  • Timer组件的interval属性从200毫秒增加到300毫秒,这可能会影响用户界面的响应性。
  • 移除了switch_on_staticswitch_off_staticname属性,但没有提供替代的静态图标资源,可能会导致开关的显示异常。
  • 删除了switch_on_static.dciswitch_off_static.dci文件,如果这些图标是必要的,那么删除操作可能会导致资源缺失。

是否建议立即修改:

  • 需要确认name属性的计算逻辑更改是否符合预期行为,并确保不会对用户界面产生负面影响。
  • 应该评估Timer组件的interval变化对用户体验的影响,并确保不会导致性能问题。
  • 需要确认删除静态图标资源是否是有意为之,并确保相关功能仍然正常工作。

@kegechen kegechen merged commit a3d0782 into linuxdeepin:dev/animation Aug 9, 2024
17 of 20 checks passed
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants