chore: dci icon contorl support animation #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kegechen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Jul 18, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#362
|
Doc Check bot
|
18202781743
reviewed
Jul 18, 2024
| @@ -31,11 +72,10 @@ void DQuickDciIconImageItemPrivate::maybeUpdateUrl() | |||
| return DQuickIconImagePrivate::maybeUpdateUrl(); | |||
| } | |||
|
|
|||
| QUrl url; | |||
| url.setScheme(QLatin1String("image")); | |||
There was a problem hiding this comment.
player 加载也可以改成异步。
zccrs
requested changes
Jul 19, 2024
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Jul 24, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#362
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Jul 25, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#362
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Jul 25, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#362
_._20240725113815.mp4 |
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Jul 25, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#362
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Jul 25, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#362
18202781743
reviewed
Jul 25, 2024
src/private/dquickdciiconimage.cpp
Outdated
| QString iconPath = findDciIconPath(parentPriv->imageItem->name(), appIconThemeName()); | ||
|
|
||
| // 防止频繁构造 dciicon | ||
| if (player->property("_d_dci_icon_path").toString() != iconPath) { |
There was a problem hiding this comment.
这个每次都是重新构造一个 DDciIcon， 只能说在 DQuickDciIconImageItemPrivate 加一个 iconPathCache
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Jul 26, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#362
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Jul 26, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#362
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Jul 30, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#362
update checkbox / radio / switch dci icons switch: disable hover and set static image before after play animation(use timer for now)
button group ( ButtonBox/ToolButton)
deepin pr auto reviewMake sure to use the correct icon name for switch buttons |
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Jul 30, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update checkbox / radio dci icon
linuxdeepin/dtkgui#247