Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added blurMultiplier adjustment #352

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

xionglinlin
Copy link
Contributor

The blur effect can be adjusted by blurMultiplier

Issue: linuxdeepin/developer-center#9374

The blur effect can be adjusted by blurMultiplier

Issue: linuxdeepin/developer-center#9374
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jun 21, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#352
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • FloatingPanel.qml中新增的blurMultiplier属性在InWindowBlur组件中没有使用,可能是不必要的添加。
  • InWindowBlur组件中的multiplier属性被标记为readonly,但在FloatingPanel.qml中没有看到相应的修改,这可能意味着multiplier属性不应该被设置。
  • radius属性的默认值在InWindowBlur组件中被设置为blur.blurMax,但在FloatingPanel.qml中没有看到对radius属性的修改,这可能意味着radius属性不应该被设置。

是否建议立即修改:

  • 是,应该确认blurMultiplier属性的必要性,并确保radius属性的默认值不会被修改。如果radius属性的默认值不应该被修改,那么应该从InWindowBlur组件中移除radius属性的默认值设置。

@xionglinlin
Copy link
Contributor Author

/review @18202781743

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, xionglinlin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 requested a review from zccrs June 21, 2024 04:24
@hudeng-go
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, xionglinlin, zccrs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xionglinlin
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 21, 2024

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit f111208 into linuxdeepin:master Jun 21, 2024
19 of 21 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Jun 24, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants