Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install loggingrules meta files #70

Merged
merged 1 commit into from
May 17, 2024

Conversation

kegechen
Copy link
Contributor

@kegechen kegechen commented May 9, 2024

dconfig meta file for dtk logging rules

@kegechen
Copy link
Contributor Author

kegechen commented May 9, 2024

linuxdeepin/dtkcore#413

@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 17, 2024

TAG Bot

New tag: 5.6.29
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #71

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 新增的"rules"配置项缺少对应的注释说明,不利于其他开发者理解配置项的用途。
  • "rules"配置项中的"name"和"description"有中文和英文版本,建议统一使用一种语言进行配置,以保持配置文件的一致性。

是否建议立即修改:

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit a59f0f1 into linuxdeepin:master May 17, 2024
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants