Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkdeclarative #157

Merged
merged 1 commit into from
Sep 2, 2024
Merged

sync: from linuxdeepin/dtkdeclarative #157

merged 1 commit into from
Sep 2, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#391

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#391
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • FloatingPanel.qml中新增了antialiasing属性,但在dquickitemviewport_p.h中没有看到相应的属性或逻辑变化。需要确认antialiasing属性的作用和使用场景。
  • dquickitemviewport_p.h中修改了maskTexture的创建逻辑,增加了d->antialiasing作为参数。需要验证这一改动是否符合预期效果,并确保所有使用该逻辑的地方都已经做了相应的修改。

是否建议立即修改:

  • 是,需要确保新增的antialiasing属性在相关文件中被正确实现和使用,并且与现有代码库保持一致。同时,需要验证dquickitemviewport_p.h中的改动不会引入新的问题或影响现有功能。

@mhduiy mhduiy merged commit 57424a8 into master Sep 2, 2024
9 of 13 checks passed
@mhduiy mhduiy deleted the sync-pr-391-nosync branch September 2, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants